The fact that "smart" flies had shorter lives than "dumb" ones isn't necessarily an indication that smartness is an evolutionary disadvantage. Maybe "smart" flies reproduce more. Maybe "smart" flies, while leading shorter lives *on average*, have more total individuals who live long enough to reproduce. Getting your genes into subsequent generations is a better yardstick of evolutionary fitness than living a long life.